Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ucan stream consumer space store add and remove count #160

Merged
merged 2 commits into from
Mar 16, 2023
Merged

feat: ucan stream consumer space store add and remove count #160

merged 2 commits into from
Mar 16, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Mar 14, 2023 •
edited
Loading

Part of metrics work #117

Adds space counters for store/add and store/remove.

@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-space-store-add-remove-count branch from 9d140d6 to ae8110b Compare March 14, 2023 11:13
@seed-deploy seed-deploy bot temporarily deployed to pr160 March 14, 2023 11:13 Inactive
@vasco-santos vasco-santos mentioned this pull request Mar 14, 2023
Closed
18 tasks
@vasco-santos vasco-santos marked this pull request as ready for review March 14, 2023 11:19
@seed-deploy
Copy link

seed-deploy bot commented Mar 14, 2023

View stack outputs

  • pr160-w3infra-CarparkStack

    Name Value
    BucketName carpark-pr160-0
    Region us-east-2

  • pr160-w3infra-SatnavStack

    Name Value
    BucketName satnav-pr160-0
    Region us-east-2

  • pr160-w3infra-UploadApiStack

    Name Value
    ApiEndpoint https://uxvt2pnoya.execute-api.us-east-2.amazonaws.com
    CustomDomain https://pr160.up.web3.storage

  • pr160-w3infra-BusStack

  • pr160-w3infra-ReplicatorStack

  • pr160-w3infra-UcanInvocationStack

  • pr160-w3infra-UploadDbStack

@vasco-santos vasco-santos requested a review from alanshaw March 14, 2023 11:23
@vasco-santos vasco-santos added this to the w3up phase 3 milestone Mar 14, 2023
@vasco-santos vasco-santos mentioned this pull request Mar 14, 2023
Closed
83 tasks
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-space-store-add-remove-count branch from ae8110b to 9d23e80 Compare March 15, 2023 10:06
@seed-deploy seed-deploy bot temporarily deployed to pr160 March 15, 2023 10:07 Inactive
@vasco-santos vasco-santos self-assigned this Mar 15, 2023
alanshaw
alanshaw approved these changes Mar 16, 2023
View reviewed changes
ucan-invocation/functions/space-metrics-store-remove-total.js Outdated
tracesSampleRate: 1.0,
})

const STORE_REMOVE = 'store/remove'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should come from @web3-storage/capabilities so that if they change we'll know here.

@seed-deploy seed-deploy bot temporarily deployed to pr160 March 16, 2023 15:10 Inactive
@vasco-santos vasco-santos force-pushed the feat/ucan-stream-consumer-space-store-add-remove-count branch from 5945d48 to dfcfe9e Compare March 16, 2023 15:13
@seed-deploy seed-deploy bot temporarily deployed to pr160 March 16, 2023 15:15 Inactive
@vasco-santos vasco-santos merged commit 7728718 into main Mar 16, 2023
@vasco-santos vasco-santos deleted the feat/ucan-stream-consumer-space-store-add-remove-count branch March 16, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@vasco-santos vasco-santos

Labels
None yet
Projects
None yet
Milestone
w3up phase 3
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @alanshaw