fix: remove warnings using shebang #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supress node warnings as we are a CLI. No need to scare the users about the experimental status of things. patching emit didn't work. I thought it did, but it seems not. This works, but i have no idea what windows will do with it. _before_ ```sh ❯ ./bin.js up ~/Pictures/3.jpg 1 file (0.2MB) ⠋ Storing(node:39756) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time (Use `node --trace-warnings ...` to show where the warning was created) bagbaieraytfm7hxlzzr4vmckazjiiwraozzrcj2bwqsipi5mtzgyxfc523lq ``` _after_ ```sh ❯ ./bin.js up ~/Pictures/3.jpg 1 file (0.2MB) bagbaieraytfm7hxlzzr4vmckazjiiwraozzrcj2bwqsipi5mtzgyxfc523lq ``` License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Dec 15, 2022
alanshaw
pushed a commit
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.1...v1.1.0) (2023-01-11) ### Features * add support for sharded CAR uploads ([#36](#36)) ([b055c78](b055c78)) * adds `w3 rm <root-cid>` cmd ([#20](#20)) ([899a4d4](899a4d4)) ### Bug Fixes * remove warnings using shebang ([#33](#33)) ([f3a1aac](f3a1aac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supress node warnings as we are a CLI. No need to scare the users about the experimental status of things.
patching emit didn't work. I thought it did, but it seems not. This works, but i have no idea what windows will do with it.
before
after
❯ ./bin.js up ~/Pictures/3.jpg 1 file (0.2MB) bagbaieraytfm7hxlzzr4vmckazjiiwraozzrcj2bwqsipi5mtzgyxfc523lqLicense: MIT
Signed-off-by: Oli Evans oli@protocol.ai