fix(delegationStorage): find delegations call was not returning results #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Feb 13, 2025
hannahhoward
pushed a commit
that referenced
this pull request
Feb 13, 2025
🤖 I have created a release *beep* *boop* --- ## [2.28.0](v2.27.0...v2.28.0) (2025-02-13) ### Features * **freeway:** put prod indexer usage to 50% ([#158](#158)) ([6bd8e90](6bd8e90)) ### Bug Fixes * **delegationStorage:** find delegations call was not returning results ([#159](#159)) ([9cd6e57](9cd6e57)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixed async operation bug in delegation retrieval logic
Changes
forEachloop toPromise.all(result.keys.map)awaitto ensure all delegations are fully loaded before returning resultsResolves #156