Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update createSpace docs #21

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

fforbeck
Copy link
Member

@fforbeck fforbeck commented Dec 11, 2024

Context

Added the explanation about how to create a space and authorize a Gateway to serve the content of the space.

  • JS Client
  • W3 CLI

Related Issues

@fforbeck fforbeck self-assigned this Dec 11, 2024
@fforbeck fforbeck requested review from travis and alanshaw December 11, 2024 16:34
@fforbeck fforbeck force-pushed the feat/create-space-content-serve branch from 1c94d8f to 32bc18d Compare December 11, 2024 16:36
@fforbeck fforbeck force-pushed the feat/create-space-content-serve branch 3 times, most recently from e02d5a8 to b8077bf Compare December 11, 2024 19:07
Signed-off-by: Felipe Forbeck <felipe.forbeck@gmail.com>
@fforbeck fforbeck force-pushed the feat/create-space-content-serve branch from be87597 to 0f14911 Compare December 16, 2024 19:15
@fforbeck fforbeck requested a review from travis December 16, 2024 19:16
fforbeck added a commit to storacha/w3up that referenced this pull request Dec 19, 2024
### Context  
While updating the `web3-storage` docs, `w3cli`, and `@storacha/client`,
I found it inconvenient to repeatedly define the gateway DID and URL
every time I created a space. Also, if we don't provide the
`skipGatewayAuthorization=true`, it will throw an error saying it is
required to provide the gateway services to authorize.

### Changes
Following @travis suggestion (see:
storacha/docs#21 (comment)), I've
updated the client to automatically authorize the Storacha Gateway
(Production) by default if `skipGatewayAuthorization` is not set to
`true` and `authorizeGatewayServices` is not provided or is empty.

Once approved, this change will need to be ported to
[upload-service/w3up-client](https://github.com/storacha/upload-service/tree/main/packages/w3up-client).

And the PR storacha/freeway#135 needs to be
merged before this change gets released.
@fforbeck fforbeck merged commit 3820778 into main Dec 19, 2024
4 checks passed
@fforbeck fforbeck deleted the feat/create-space-content-serve branch December 19, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants