-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove upload #90
Conversation
Website preview 🔗✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh cool! thanks, I started looking into it yesterday but did not do much progress as I did not touch console before.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to unify SWR key generation, but can ship without that if you're tryna get this out the door asap!
await client?.remove(root, { shards: true }) | ||
setRemoveConfirmModalOpen(false) | ||
// ensure list data is fresh | ||
mutate(`/space/${spaceDID}/uploads?cursor=&pre=`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to pull this key string generation out to a function that can also be used here: https://github.com/web3-storage/console/blob/main/src/app/space/%5Bdid%5D/page.tsx#L25
🤖 I have created a release *beep* *boop* --- ## [1.5.0](w3console-v1.4.1...w3console-v1.5.0) (2024-02-09) ### Features * remove upload ([#90](#90)) ([92aaabf](92aaabf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [1.5.0](storacha/console@w3console-v1.4.1...w3console-v1.5.0) (2024-02-09) ### Features * remove upload ([#90](storacha/console#90)) ([92aaabf](storacha/console@92aaabf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds a remove button and confirmation modal to make sure folks really want to remove the upload.
Button on upload info page
Button hover state (red so you know it is dangerous)
Confirmation modal
resolves storacha/w3up#1298