Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove upload #90

Merged
merged 5 commits into from
Feb 9, 2024
Merged

feat: remove upload #90

merged 5 commits into from
Feb 9, 2024

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Feb 8, 2024

Adds a remove button and confirmation modal to make sure folks really want to remove the upload.

Button on upload info page

Screenshot 2024-02-08 at 13 47 55

Button hover state (red so you know it is dangerous)

Screenshot 2024-02-08 at 13 48 56

Confirmation modal

Screenshot 2024-02-08 at 13 49 00

resolves storacha/w3up#1298

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Website preview 🔗✨

build log

Copy link

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool! thanks, I started looking into it yesterday but did not do much progress as I did not touch console before.

LGTM

Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to unify SWR key generation, but can ship without that if you're tryna get this out the door asap!

await client?.remove(root, { shards: true })
setRemoveConfirmModalOpen(false)
// ensure list data is fresh
mutate(`/space/${spaceDID}/uploads?cursor=&pre=`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to pull this key string generation out to a function that can also be used here: https://github.com/web3-storage/console/blob/main/src/app/space/%5Bdid%5D/page.tsx#L25

@alanshaw alanshaw merged commit 92aaabf into main Feb 9, 2024
5 checks passed
@alanshaw alanshaw deleted the feat/remove-upload branch February 9, 2024 10:08
alanshaw pushed a commit that referenced this pull request Feb 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](w3console-v1.4.1...w3console-v1.5.0)
(2024-02-09)


### Features

* remove upload
([#90](#90))
([92aaabf](92aaabf))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fforbeck pushed a commit to storacha/upload-service that referenced this pull request Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](storacha/console@w3console-v1.4.1...w3console-v1.5.0)
(2024-02-09)


### Features

* remove upload
([#90](storacha/console#90))
([92aaabf](storacha/console@92aaabf))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't upload/remove from console.web3.storage
3 participants