feat(rule): remove 'when' #614
Conversation
|
@P0lip we have never documented this functionality so we could potentially release this as not a breaking change. If we want to play it cautious (Hyrum's Law is a thing) we can bundle this with another breaking change: clearing out the old TS cruf we've had floating around. https://github.com/stoplightio/spectral/issues?q=is%3Aissue+is%3Aopen+label%3Abreaking My recommendation would be to hold off on merging this, get v4.2.0 out in the next few days if we consider it ready, then consider develop (and therefore the next release) v5.0 so we can make these breaking changes and clear out a bunch of junk, along with this undocumented feature. |
BREAKING CHANGE: 'when' is gone. You can write a jsonpath extension instead
ef448b1 to
70fc34d
Compare
|
Seeing as we have a bunch of breaks coming in lets merge this, and #561 and all the other breaks and make a 5.0. |
BREAKING CHANGE: 'when' is gone. You can write a jsonpath extension instead
Closes #585
Checklist
Does this PR introduce a breaking change?
Don't know 🤔@philsturgeon @marbemac do we treat it as breaking or not?
I think we made a change to rules (like removed a rule) in the past, and didn't mark it as breaking.