Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support overrides in rulesets #1684

Merged
merged 2 commits into from
Jun 28, 2021
Merged

feat(core): support overrides in rulesets #1684

merged 2 commits into from
Jun 28, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jun 22, 2021

Closes #1021

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

How to test this PR?

  • clone the repo
  • `npx lerna bootstrap
  • yarn build
  • lerna run build.binary

Then, add some rulesets, files, etc.
The binary is located under packages/cli/binaries.

@P0lip P0lip added enhancement New feature or request v6 Scheduled to be released in v6 labels Jun 22, 2021
@P0lip P0lip self-assigned this Jun 22, 2021
@P0lip P0lip marked this pull request as ready for review June 23, 2021 14:13
@P0lip P0lip requested review from mnaumanali94, a team and billiegoose and removed request for a team June 23, 2021 14:13
Comment on lines +18 to +19
// if you stumbled upon this file and want to use this rule in your own ruleset - do NOT.
// it doesn't cover many cases, and it's only purpose is to serve us as a test artefact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Contributor

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0lip P0lip merged commit 153d685 into develop Jun 28, 2021
@P0lip P0lip deleted the feat/overrides branch June 28, 2021 10:58
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-cli-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

stoplight-bot pushed a commit that referenced this pull request Jul 8, 2021
# @stoplight/spectral-cli-v1.0.0 (2021-07-08)

### Features

* **cli:** demand some ruleset to be present ([#1699](#1699)) ([3baba29](3baba29))
* **cli:** implement --stdin-filepath flag ([#1712](#1712)) ([45b15a2](45b15a2))
* **core:** support overrides in rulesets ([#1684](#1684)) ([153d685](153d685))
* **core:** use double quotes in errors reported by Ajv ([#1718](#1718)) ([dd2a166](dd2a166))
* **ruleset-migrator:** implement ruleset migrator  ([#1698](#1698)) ([efa5c50](efa5c50))
* **ruleset-migrator:** inline external rulesets & support exceptions  ([#1711](#1711)) ([2a1d2d3](2a1d2d3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released v6 Scheduled to be released in v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Overrides" similar to eslint
3 participants