fix: nested extends broken in rulesets #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab1cf93 to
39b17ec
Compare
This was referenced Jan 10, 2021
83aa943 to
a893999
Compare
a893999 to
91e665d
Compare
domagojk
previously approved these changes
Jan 14, 2021
Co-authored-by: Domagoj Kriskovic <dom@stoplight.io>
P0lip
added a commit
that referenced
this pull request
Mar 8, 2021
* fix(ruleset): nested extends not working correctly * Update src/rule.ts Co-authored-by: Domagoj Kriskovic <dom@stoplight.io> Co-authored-by: Domagoj Kriskovic <dom@stoplight.io>
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
Fixes #1380
I'm going to split this PR into 2 smaller ones.
I cleaned up all tests we had, so that they don't rely on OAS ruleset as well as moved a few files around.
Prior to that, I spent a bit of time improving the current ruleset API we have - at the moment it's not the most convenient for JS consumers.
The work can be found on feat/nicer-rulesets branch
Checklist
Does this PR introduce a breaking change?