Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ruleset): optional pointer for exceptions #1405

Merged
merged 2 commits into from
Nov 25, 2020
Merged

feat(ruleset): optional pointer for exceptions #1405

merged 2 commits into from
Nov 25, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 19, 2020

Makes pointers optional as described in #1002
Addresses https://github.com/stoplightio/platform-internal/issues/4523

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the enhancement New feature or request label Nov 19, 2020
@P0lip P0lip requested a review from philsturgeon November 19, 2020 17:50
@P0lip P0lip self-assigned this Nov 19, 2020
@P0lip P0lip force-pushed the feat/exceptions-optional-pointer branch from 6aa176a to 05f19de Compare November 20, 2020 13:21
@P0lip P0lip force-pushed the feat/exceptions-optional-pointer branch from 05f19de to ff10df1 Compare November 20, 2020 13:22
@P0lip P0lip requested a review from a team November 23, 2020 12:24
billiegoose
billiegoose approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Sweet and simple.

@P0lip P0lip merged commit 4985beb into develop Nov 25, 2020
@P0lip P0lip deleted the feat/exceptions-optional-pointer branch November 25, 2020 23:13
@jcolaco-nmz
Copy link

@P0lip Do you have any estimation on when will this be released?

@P0lip
Copy link
Contributor Author

P0lip commented Dec 11, 2020

Hey @jcolaco-nmz, no specific timeline yet, but I'm hoping to get it out before 2020 ends.

@P0lip P0lip mentioned this pull request Dec 11, 2020
Closed
4 tasks
P0lip added a commit that referenced this pull request Jan 4, 2021
@P0lip
feat(ruleset): optional pointer for exceptions (#1405)
a81733c
@P0lip
Copy link
Contributor Author

P0lip commented Jan 4, 2021

@jcolaco-nmz Hey, just wanted to let you know the change has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billiegoose billiegoose billiegoose approved these changes

@philsturgeon philsturgeon Awaiting requested review from philsturgeon

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0lip @jcolaco-nmz @billiegoose