-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable clusterlifecycle-metric on AKS #984
enable clusterlifecycle-metric on AKS #984
Conversation
572e2e0
to
7bb9452
Compare
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
7bb9452
to
96084a8
Compare
Quality Gate passedIssues Measures |
/assign @dislbenn @cameronmwall |
Based on the comments in Jira: https://issues.redhat.com/browse/ACM-14477, this PR should not be merged into the current release branch. |
/hold |
/unhold |
@dislbenn could you please review this again? I think we can make it into 2.8. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
Description
Please provide a brief description of the purpose of this pull request.
Related Issue
https://issues.redhat.com/browse/ACM-14477
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist
Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line:
/cc @reviewer1 @reviewer2
Definition of Done