Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable clusterlifecycle-metric on AKS #984

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

zhiweiyin318
Copy link
Contributor

@zhiweiyin318 zhiweiyin318 commented Sep 27, 2024

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

https://issues.redhat.com/browse/ACM-14477

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Copy link

@zhiweiyin318 zhiweiyin318 changed the title [wip] enable clusterlifecycle-metric on AKS enable clusterlifecycle-metric on AKS Oct 2, 2024
@zhiweiyin318
Copy link
Contributor Author

/assign @dislbenn @cameronmwall

@dislbenn
Copy link
Collaborator

dislbenn commented Oct 7, 2024

Based on the comments in Jira: https://issues.redhat.com/browse/ACM-14477, this PR should not be merged into the current release branch.

@dislbenn
Copy link
Collaborator

dislbenn commented Oct 7, 2024

/hold

@zhiweiyin318
Copy link
Contributor Author

/unhold

@zhiweiyin318
Copy link
Contributor Author

@dislbenn could you please review this again? I think we can make it into 2.8. thanks.

Copy link
Collaborator

@dislbenn dislbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 02fae54 into stolostron:main Nov 14, 2024
9 checks passed
@zhiweiyin318 zhiweiyin318 deleted the enable-clc-metric branch November 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants