Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-7785] Updated hive image-repo ref in hack config #538

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[ACM-7785] Updated hive image-repo ref in hack config #538

merged 3 commits into from
Oct 19, 2023

Conversation

dislbenn
Copy link
Collaborator

@dislbenn dislbenn commented Oct 12, 2023

Description

Updated hive config to use the image-repo reference instead of passing the image-repo and image-tags overrides.

Related Issue

https://issues.redhat.com/browse/ACM-7785

Changes Made

Updated hive reference in hack/bundle-automation/config.yaml

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

/cc @joeg-pro

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
Copy link
Contributor

@joeg-pro joeg-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the disable_image-valiation property being added to the config.

hack/bundle-automation/config.yaml Outdated Show resolved Hide resolved
Signed-off-by: Joe Gdaniec <jgdaniec@redhat.com>
@dislbenn dislbenn changed the title Updated hive image-repo ref in hack config [ACM-7785] Updated hive image-repo ref in hack config Oct 19, 2023
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@joeg-pro
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, joeg-pro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 526ed59 into stolostron:main Oct 19, 2023
@dislbenn dislbenn deleted the update-hive-config branch January 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants