Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-13578] Onboarded cluster-api-provider-aws (CAPA) component to MCE 2.8 #1145

Conversation

dislbenn
Copy link
Collaborator

@dislbenn dislbenn commented Dec 16, 2024

Description

Updated MCE operator to support new cluster-api-provider-aws (CAPA) component.
Follow up to #1128 PR.

Related Issue

https://issues.redhat.com/browse/ACM-13578

Changes Made

Added new toggle for enable/disabling cluster-api-provider-aws component within MCE.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@dislbenn dislbenn changed the title [ACM-13578] Onboarded cluster-api-provider-aws (CAPA) component to MCE 2. [ACM-13578] Onboarded cluster-api-provider-aws (CAPA) component to MCE 2.8 Dec 16, 2024
@dislbenn dislbenn closed this Jan 7, 2025
@dislbenn dislbenn force-pushed the onboard-cluster-api-provider-aws-2.8 branch from 9b4a0cd to 0eb2005 Compare January 7, 2025 23:11
@openshift-ci openshift-ci bot removed the approved label Jan 7, 2025
Signed-off-by: dislbenn <dbennett@redhat.com>
@dislbenn dislbenn reopened this Jan 7, 2025
@openshift-ci openshift-ci bot added the approved label Jan 7, 2025
@dislbenn
Copy link
Collaborator Author

dislbenn commented Jan 7, 2025

/retest

Signed-off-by: dislbenn <dbennett@redhat.com>
@dislbenn dislbenn force-pushed the onboard-cluster-api-provider-aws-2.8 branch from acc4c74 to 64f5008 Compare January 8, 2025 12:53
@dislbenn
Copy link
Collaborator Author

dislbenn commented Jan 8, 2025

/hold

@dislbenn
Copy link
Collaborator Author

dislbenn commented Jan 8, 2025

/unhold

Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
@dislbenn
Copy link
Collaborator Author

dislbenn commented Jan 9, 2025

/retest

…urce

Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
@dislbenn dislbenn requested a review from gparvin January 9, 2025 19:01
@cameronmwall
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9afb272 into stolostron:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants