chore: extract strings from isolation section for translation (#237) #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering if can't use simpler keys (e.g. "mouseClick" over "optionsIsolationMouseClick").
At the moment they give some context, but we could limit use of them to strings only used in once place (e.g. "No Isolated Domains added yet").
We could use the description tag for ambiguous strings, for example:
Or perhaps even:
Bit of a pain when you add "optionsIsolationPerDomainMouseClickLeftMouse" and then find it's actually used elsewhere too.