Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Prevent hardcoded install #1431

Conversation

sansyse
Copy link

@sansyse sansyse commented Sep 30, 2024

  • Introduced an environment variable that prevents the CMake installation script from installing modprobe config and udev rules to /etc/.

(Closes #1430)

- Introduced an environment variable that prevents the CMake
  installation script from installing modprobe config and udev
  rules to /etc/.
@Nightwalker-87 Nightwalker-87 self-requested a review October 3, 2024 19:35
@Nightwalker-87 Nightwalker-87 added this to the v1.8.1 milestone Oct 3, 2024
@Nightwalker-87 Nightwalker-87 changed the title [feat] prevent hardcoded install (closes #1430) [feature] Prevent hardcoded install Oct 3, 2024
CMakeLists.txt Show resolved Hide resolved
@Nightwalker-87 Nightwalker-87 requested a review from Ant-ON October 3, 2024 19:55
@Nightwalker-87
Copy link
Member

@Ant-ON: What's your opinion on this approach?

@Ant-ON
Copy link
Collaborator

Ant-ON commented Oct 17, 2024

@Nightwalker-87 I think this modification is unnecessary. An experienced user who needs a custom installation can manually place executable and configuration files. There's not much that needs to be done by hand. This modification raises more questions than it provides in functionality.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Oct 17, 2024
@Nightwalker-87 Nightwalker-87 removed the request for review from Ant-ON October 17, 2024 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Prevent installing of hardcoded modprobe config and udev rules
3 participants