Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unlink command #747

Merged
merged 2 commits into from
May 13, 2019
Merged

feat: add unlink command #747

merged 2 commits into from
May 13, 2019

Conversation

GunnarHolwerda
Copy link
Contributor

@GunnarHolwerda GunnarHolwerda commented May 10, 2019 •
edited by stipsan
Loading

  • Adds support for the unlink command.
  • Delegates off to del as the behavior when running in memory would behave the same. I have verified that unlink sends the same keyspace notifications as del too.

Fixes #746

@AppVeyorBot
Copy link

❌ Build ioredis-mock 1.0.3621 failed (commit 32a1051cad by @GunnarHolwerda)

@AppVeyorBot
Copy link

❌ Build ioredis-mock 1.0.3622 failed (commit 900f52bed0 by @GunnarHolwerda)

@AppVeyorBot
Copy link

❌ Build ioredis-mock 1.0.3623 failed (commit 36b0029f5b by @GunnarHolwerda)

@AppVeyorBot
Copy link

❌ Build ioredis-mock 1.0.3624 failed (commit 52818f8b93 by @GunnarHolwerda)

@codeclimate
Copy link

codeclimate bot commented May 10, 2019 •
edited
Loading

Code Climate has analyzed commit ec2472a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.5% (0.0% change).

View more on Code Climate.

@AppVeyorBot
Copy link

✅ Build ioredis-mock 1.0.3625 completed (commit 5ca2181bcf by @GunnarHolwerda)

@GunnarHolwerda
Copy link
Contributor Author

Sorry for all of the fails. Couldn't run the unit tests locally because I was on Windows 😄

@GunnarHolwerda GunnarHolwerda mentioned this pull request May 10, 2019
Closed
@stipsan stipsan changed the title Add unlink command feat: add unlink command May 13, 2019
stipsan
stipsan approved these changes May 13, 2019
View reviewed changes
Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for contributing this! 😄

@stipsan stipsan merged commit 6ef180a into stipsan:master May 13, 2019
@stipsan
Copy link
Owner

stipsan commented May 13, 2019

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlink command is missing
3 participants
@GunnarHolwerda @AppVeyorBot @stipsan