Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement zcard command #702 #732

Merged
merged 5 commits into from
May 13, 2019
Merged

feat: implement zcard command #702 #732

merged 5 commits into from
May 13, 2019

Conversation

ljht
Copy link
Contributor

@ljht ljht commented Apr 23, 2019

Fixes #702

@codeclimate
Copy link

codeclimate bot commented Apr 23, 2019

Code Climate has analyzed commit a341674 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.5% (0.0% change).

View more on Code Climate.

@MichaelHirn
Copy link

Would be great if we could get this merged :)

I tried it out locally and it does fix the zcard problem, but I can't just npm install from @ljht's commit, because the package.json doesn't have a version specified - that's fine for local but messes with my build process.

Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🎉 Looks good to merge for me 👍

And thanks @MichaelHirn for helping with testing it 😄

@stipsan stipsan merged commit 3b36191 into stipsan:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ioredis-mock to support zcard
3 participants