Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zscore command #577

Merged
merged 1 commit into from
Oct 12, 2018
Merged

feat: add zscore command #577

merged 1 commit into from
Oct 12, 2018

Conversation

kylewm
Copy link
Contributor

@kylewm kylewm commented Oct 12, 2018

https://redis.io/commands/ZSCORE

Returns the score of member in the sorted set at key.

If member does not exist in the sorted set, or key does not exist, nil is returned.

Return value
Bulk string reply: the score of member (a double precision floating point number), represented as string.

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2018

Code Climate has analyzed commit 6e14a1d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

export function zscore(key, member) {
const map = this.data.get(key);

// @TODO investigate a more stable way to detect sorted lists
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

@stipsan stipsan changed the title implement zscore command feat: add zscore command Oct 12, 2018
Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏😄

@stipsan stipsan merged commit 0c69f9b into stipsan:master Oct 12, 2018
@stipsan
Copy link
Owner

stipsan commented Oct 12, 2018

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kylewm
Copy link
Contributor Author

kylewm commented Oct 12, 2018

Thanks so much for the ⚡️ review!

@kylewm kylewm deleted the zscore branch October 12, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants