Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zrevrangebyscore command #442

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Add zrevrangebyscore command #442

merged 1 commit into from
Jun 4, 2018

Conversation

kylewm
Copy link
Contributor

@kylewm kylewm commented Jun 4, 2018

  • Add support for zrevrangebyscore
  • Support optional parameter WITHSCORES for zrangebyscore and zrevrangebyscore

@kylewm
Add zrevrangebyscore command
be5d193 
* Add support for zrevrangebyscore
* Support optional parameter WITHSCORES for zrangebyscore and zrevrangebyscore
stipsan
stipsan approved these changes Jun 4, 2018
View reviewed changes
Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid stuff. I am going to merge this 👍

compat.md
@@ -168,7 +168,7 @@
| [zremrangebyscore](http://redis.io/commands/ZREMRANGEBYSCORE) | :white_check_mark: | :x: |
| [zrevrange](http://redis.io/commands/ZREVRANGE) | :white_check_mark: | :white_check_mark: |
| [zrevrangebylex](http://redis.io/commands/ZREVRANGEBYLEX) | :white_check_mark: | :x: |
| [zrevrangebyscore](http://redis.io/commands/ZREVRANGEBYSCORE) | :white_check_mark: | :x: |
| [zrevrangebyscore](http://redis.io/commands/ZREVRANGEBYSCORE) | :white_check_mark: | :white_check_mark: |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the compat list 😄

src/commands/zrange-command.common.js
@@ -17,3 +17,35 @@ export function slice(arr, s, e) {
}
return arr.slice(start, end + 1);
}

export function parseLimit(input) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate that you take the time to refactor things and improve the codebase while adding features 👏👌

@stipsan stipsan merged commit a9e243e into stipsan:master Jun 4, 2018
stipsan added a commit that referenced this pull request Jun 4, 2018
@stipsan
Changelog: 🚀
0f9f926 
## Added
 
- `zrevrangebyscore` commands (#442 @kylewm)
- `zrem` and `zincrby` commands (#443 @kylewm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylewm @stipsan