scan command implementation #329 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DrMegavolt This is awesome 😄 🥇 Do you mind writing tests for the new code while at it? Also is package-lock.json needed? If you're pressed on time I can join in and write tests tomorrow 🙂 |
|
@stipsan I can add |
|
Cool, merged it in 👍 I’ll slice a release after I’ve gone over the other PRs and updated the changelog 😃 |
stipsan
added a commit
that referenced
this pull request
Nov 15, 2017
## New Commands ### SCAN command (#334 @DrMegavolt) ```js redis .scan(0, 'MATCH', 'foo*', 'COUNT', 1) .then(result => console.log(result)) ``` ### LRANGE command (#335 @sseidametov) ```js redis .lrange('myKey', 0, 2) .then(result => console.log(result)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation for scan command.
scan-command.helperallow all kind *SCAN commandif this is ok, I can add them as well