Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* swapped out : for , for the regex replacement hack to work on windo… #806

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

jckhng
Copy link
Contributor

@jckhng jckhng commented Nov 2, 2022

…ws system. windows paths uses :, e.g. c:\project\pangolin. this allow cmake to generate shaders.cpp correctly on windows systems.

this should fix #805

…ws system. windows paths uses :, e.g. c:\project\pangolin. this allow cmake to generate shaders.cpp correctly on windows systems.
@stevenlovegrove stevenlovegrove merged commit 53545bc into stevenlovegrove:master Dec 30, 2022
@stevenlovegrove
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building on Windows : CMake Error at Pangolin/cmake/EmbedShaderFiles.cmake:26
2 participants