🐛 Fix tabs visibility on formula fullscreen (elastic#113268)

stephmilovic · Sep 29, 2021 · 04497da · 04497da
1 parent 682a1c1
commit 04497da
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx
@@ -680,7 +680,7 @@ export function DimensionEditor(props: DimensionEditorProps) {
   const hasFormula =
     !isFullscreen && operationSupportMatrix.operationWithoutField.has(formulaOperationName);
 
-  const hasTabs = hasFormula || supportStaticValue;
+  const hasTabs = !isFullscreen && (hasFormula || supportStaticValue);
 
   return (
     <div id={columnId}>

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx
@@ -2263,7 +2263,7 @@ describe('IndexPatternDimensionEditorPanel', () => {
     ).toBeTruthy();
   });
 
-  it('should now show the static_value tab when not supported', () => {
+  it('should not show the static_value tab when not supported', () => {
     const stateWithFormulaColumn: IndexPatternPrivateState = getStateWithColumns({
       col1: {
         label: 'Formula',
@@ -2337,4 +2337,28 @@ describe('IndexPatternDimensionEditorPanel', () => {
       wrapper.find('[data-test-subj="lens-dimensionTabs-static_value"]').first().prop('isSelected')
     ).toBeTruthy();
   });
+
+  it('should not show any tab when formula is in full screen mode', () => {
+    const stateWithFormulaColumn: IndexPatternPrivateState = getStateWithColumns({
+      col1: {
+        label: 'Formula',
+        dataType: 'number',
+        isBucketed: false,
+        operationType: 'formula',
+        references: ['ref1'],
+        params: {},
+      },
+    });
+
+    wrapper = mount(
+      <IndexPatternDimensionEditorComponent
+        {...defaultProps}
+        state={stateWithFormulaColumn}
+        supportStaticValue
+        isFullscreen
+      />
+    );
+
+    expect(wrapper.find('[data-test-subj="lens-dimensionTabs"]').exists()).toBeFalsy();
+  });
 });