Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test for BytesValue on env=node #440

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

boukeversteegh
Copy link
Collaborator

Thanks for the fast merge of #439 !

I hoped to squeeze in a last minute test-case, but I was not fast enough 😉

Here it is post merge.

@boukeversteegh boukeversteegh marked this pull request as draft December 8, 2021 23:17
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great! Sorry, I think I was just in meetings today and wanted to feel productive so hit merge on some PRs :-D I'll let you merge going forward as yeah I'm not in a rush. Thanks for the test!

@boukeversteegh
Copy link
Collaborator Author

Haha, no it's great actually. I love the speed at which things release in this project, it's very motivating to contribute. Thanks for the merge!

I also just discovered you can make a draft PR 😊 very handy

@boukeversteegh boukeversteegh marked this pull request as ready for review December 9, 2021 10:19
@boukeversteegh boukeversteegh merged commit dd0928e into main Dec 9, 2021
@boukeversteegh boukeversteegh deleted the fix/368-test branch December 9, 2021 10:20
@stephenh
Copy link
Owner

stephenh commented Dec 9, 2021

🎉 This PR is included in version 1.93.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants