Mouseend listener never gets unregistered #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephband
added a commit
that referenced
this pull request
Jan 28, 2013
Mouseend listener never gets unregistered - fix
|
Yes, it is indeed a typo. Thank you for putting the time in on tracking that down. That's a big help! |
|
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a typo in the library. If many mouse down/up events are sent to the page, eventually the mouseend function gets called bajillions of times because it is registered on each mousedown but never unregistered. This causes, for example, the issue at https://bugzilla.mozilla.org/show_bug.cgi?id=833540 in Firefox for Android.