Resolve problems discovered while testing on macOS (fixes #58) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddf51de to
bc05d89
Compare
|
With those changes all seems to be working well though. Thank you for the submission 🙂 |
|
Fix it for me too, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues I found when testing on macOS. See issue #58 for details.
scripts/test.shso that it will work "out of the box" on macOS. I did this in a way that should not interfere with existing users and provides the pattern for solving the same problem if it might arise on other platforms in the future.tests/bot_detection/test_browserscan.pydoes not wait long enough for the javascript to render the element in the DOM that the test is looking for. I added a smallpage.wait()that resolves this and now the tests pass consistently.