fix: removing LoadingOverlay from Trending and Popular components

stephane-r · Oct 24, 2023 · a203d99 · a203d99
1 parent 104cd2b
commit a203d99
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/components/Popular.tsx b/src/components/Popular.tsx
@@ -16,11 +16,11 @@ export const Popular: React.FC<PopularProps> = memo(({ horizontal }) => {
   const { t } = useTranslation();
 
   if (!query.data) {
-    return <LoadingOverlay visible />;
+    return <Text>{t("loading")}</Text>;
   }
 
   if (query.error) {
-    return <div>{t("error")}</div>;
+    return <Text>{t("error")}</Text>;
   }
 
   if (horizontal) {

diff --git a/src/components/Trending.tsx b/src/components/Trending.tsx
@@ -25,11 +25,11 @@ export const Trending: React.FC<TrendingProps> = memo(
     const { t } = useTranslation();
 
     if (!query.data) {
-      return <LoadingOverlay visible />;
+      return <Text>{t("loading")}</Text>;
     }
 
     if (query.error) {
-      return <div>{t("error")}</div>;
+      return <Text>{t("error")}</Text>;
     }
 
     if (horizontal) {

diff --git a/src/translations/en.json b/src/translations/en.json
@@ -240,5 +240,6 @@
   "favorite.tab.playlists": "Playlists",
   "favorite.tab.channels": "Channels",
   "favorite.tab.empty": "No favorite in this section",
-  "genre.title": "Moods & genres"
+  "genre.title": "Moods & genres",
+  "loading": "Loading..."
 }
diff --git a/src/translations/fr.json b/src/translations/fr.json
@@ -240,5 +240,6 @@
   "favorite.tab.playlists": "Playlists",
   "favorite.tab.channels": "Chaînes",
   "favorite.tab.empty": "Aucun favoris dans cette section.",
-  "genre.title": "Ambiances & genres"
+  "genre.title": "Ambiances & genres",
+  "loading": "Changement..."
 }