[everflow_testbed] extend test to cover ingress/egress mirroring on i… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngress/egress ACL table based on DUT capabilities Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
19f7464 to
78b3bb5
Compare
added 2 commits
September 3, 2019 02:36
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
wangxin
reviewed
Sep 3, 2019
|
|
||
| - name: Run testcase 3 - Remove longer prefix route. | ||
| - name: Run testcase 3 - Resolved ECMP route. |
There was a problem hiding this comment.
Need to update the test case description to be consistent with test plan.
wangxin
reviewed
Sep 3, 2019
| include: roles/test/tasks/everflow_testbed/testcase_3.yml | ||
|
|
||
| - name: Run testcase 4 - Change neighbor MAC address. | ||
| - name: Run testcase 4 - ECMP route change (add next hop). |
There was a problem hiding this comment.
Need to update the test case description to be consistent with test plan.
|
The change looks good to me except a few test case name description need to be consistent with test plan. |
added 2 commits
September 3, 2019 12:29
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Oct 15, 2019
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
added a commit
that referenced
this pull request
Oct 31, 2019
) * [everflow_testbed] extend test to cover ingress/egress mirroring on ingress/egress ACL table based on DUT capabilities Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * fix ptf port id passing Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * fix test case #4 Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * fix testcase 3,4 description Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * fix everflow policer test for egress mirroring test Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * address review comments Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Nov 4, 2019
Signed-off-by: Roman Kachur <romankac@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngress/egress ACL table based on DUT capabilities
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation