fix(goto): preserve search parameters in URL

[vjo]

What is the current behavior?

It is not possible to navigate to a URL including search parameters because they are stripped by the goto override.

Therefor, this test fails:

import { expect } from '@playwright/test';
import { test } from '@stencil/playwright';

test('Playwright', async ({ page }) => {
  const url = 'https://playwright.dev/?key=val';
  await page.goto(url);

  expect(page.url()).toBe(url); // ❌
});

There is no obvious reasons for removing the search parameters from the URL in the goto method.

GitHub Issue Number: #45

What is the new behavior?

Search parameters in the URL are preserved.

Does this introduce a breaking change?

I would like to say no, but potentially (?)

We should not rely on goto stripping the parameters but it's possible someone could have write tests expecting this behavior.

Testing

I made sure the above test works locally but it does not seem that we have unit test for these "helpers"

[tanner-reits]

@vjo I believe this is a safe change to make. Stripping the params was lingering behavior that got missed as we ported this helper from the implementation in Ionic Framework. Sorry about that!

[vjo]

@tanner-reits awesome, thank you for accepting this patch.
The team and I have been a bit confused when we started a new feature using search params 😅
All good now.

Do you know what is the schedule for the next release?

[tanner-reits]

@vjo Yep! I'm gonna try to get a release out this week!

[vjo]

@tanner-reits great, thank you.