fix(adapter): pipe dev server output to console #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, the Playwright process doesn't relay any output from the dev server to the console. This can cause confusion for users if there is a build error in the Stencil project since nothing would be logged in the console and the process would appear to hang until the timeout is reached.
GitHub Issue Number: N/A
What is the new behavior?
This commit updates the default
webServer
configuration in the Playwright config to pipe thestdout
output from the dev server through to the Playwright process.Unfortunately, AFAICT there isn't a way to terminate the process when this happens. Playwright continuously polls the url until either it: returns a valid status code (200, 300, 400, etc.) or the process timeout is reached. Returning a 500 does not end the process and even returning a code like a 400 will allow tests to execute.
Documentation
Does this introduce a breaking change?
Testing
I confirmed that the dev server output is visible from the Playwright process now.
Also tested various cases trying to get the process to terminate, but was unsuccessful.
Other information