Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): add automated dev releases #14

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore(repo): add automated dev releases #14

merged 1 commit into from
Mar 14, 2024

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Mar 13, 2024

What is the current behavior?

We don't have any support for automated dev builds.

While this may seem unneeded for a new project, it's a great way to allow us to get quick feedback from the community, and build towards automated production deployments

GitHub Issue Number: N/A

What is the new behavior?

add the ability to publish a dev build of the project to the npm registry. we do so by adding a new workflow that can be manually kicked off, release-dev. as the name implies, it creates a dev build (running the most basic/essential parts of the build pipeline) and invokes a publish to npm

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

In 7fde790, I had a push event trigger enabled such that when I pushed this branch to GitHub, a dev build would get triggered. I considered this to be safe because:

  1. It built off the same workflow/steps as the create-stencil cli, which has dev releases
  2. I tested this without publishes enabled at first (commented out)
  3. I figured worst case, since I verified the tag and version number, I'd push a bad dev release to npm
  4. <GH_ACTION_RUN> shows a successful publish to the npm registry
Run npm publish --tag dev
npm notice 
npm notice 📦  @stencil/playwright@0.1.0-dev.1710423894.3547fcc
npm notice === Tarball Contents === 
npm notice 1.4kB   LICENSE.md                                            
npm notice 22B     README.md                                             
npm notice 1.4kB   dist/create-config.d.ts                               
npm notice 216.1kB dist/index.cjs                                        
npm notice 482.9kB dist/index.cjs.map                                    
npm notice 234B    dist/index.d.ts                                       
npm notice 214.8kB dist/index.js                                         
npm notice 482.4kB dist/index.js.map                                     
npm notice 308B    dist/load-config-meta.d.ts                            
npm notice 751B    dist/matchers/index.d.ts                              
npm notice 191B    dist/matchers/to-have-first-received-event-detail.d.ts
npm notice 204B    dist/matchers/to-have-nth-received-event-detail.d.ts  
npm notice 191B    dist/matchers/to-have-received-event-detail.d.ts      
npm notice 187B    dist/matchers/to-have-received-event-times.d.ts       
npm notice 167B    dist/matchers/to-have-received-event.d.ts             
npm notice 1.7kB   dist/page/event-spy.d.ts                              
npm notice 755B    dist/page/utils/goto.d.ts                             
npm notice 150B    dist/page/utils/index.d.ts                            
npm notice 848B    dist/page/utils/locator.d.ts                          
npm notice 707B    dist/page/utils/set-content.d.ts                      
npm notice 193B    dist/page/utils/spy-on-event.d.ts                     
npm notice 588B    dist/page/utils/wait-for-changes.d.ts                 
npm notice 5.5kB   dist/playwright-declarations.d.ts                     
npm notice 446B    dist/playwright-page.d.ts                             
npm notice 132B    dist/process-constants.d.ts                           
npm notice 630B    dist/test-expect.d.ts                                 
npm notice 2.3kB   package.json                                          
npm notice === Tarball Details === 
npm notice name:          @stencil/playwright                                
npm notice version:       0.1.0-dev.1710423894.3547fcc                       
npm notice filename:      stencil-playwright-0.1.0-dev.1710423894.3547fcc.tgz
npm notice package size:  331.5 kB                                           
npm notice unpacked size: 1.4 MB                                             
npm notice shasum:        ef05b57cc4e4aab08737b0da68a32bf88c6c5948           
npm notice integrity:     sha512-rdW7jBVFf7/47[...]5Bb4PF7vTd7+Q==           
npm notice total files:   27                                                 
npm notice 

Screenshot 2024-03-14 at 9 55 40 AM

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review March 14, 2024 13:56
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner March 14, 2024 13:56
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

add the ability to publish a dev build of the project to the npm
registry. we do so by adding a new workflow that can be manually kicked
off, `release-dev`. as the name implies, it creates a dev build (running
the most basic/essential parts of the build pipeline) and invokes a
publish to npm
@rwaskiewicz rwaskiewicz enabled auto-merge March 14, 2024 15:37
@rwaskiewicz rwaskiewicz added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit fbf50a7 Mar 14, 2024
3 checks passed
@rwaskiewicz rwaskiewicz deleted the dev-release branch March 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants