Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Normalise CodeChunk, CodeExpr, Code and CodeBlock #92

Closed
nokome opened this issue Jul 18, 2019 · 1 comment
Closed

Normalise CodeChunk, CodeExpr, Code and CodeBlock #92

nokome opened this issue Jul 18, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request released
Milestone

Comments

@nokome
Copy link
Member

nokome commented Jul 18, 2019

Currently CodeChunk & CodeExpr extend SoftwareSourceCode while Code and CodeBlock don't. This leads to difference n property names for nodes that are very similar.

@nokome nokome added the enhancement New feature or request label Jul 18, 2019
@nokome nokome added this to the v1.0-beta milestone Jul 18, 2019
@nokome nokome self-assigned this Jul 29, 2019
@nokome nokome modified the milestones: Beta, v1.0 Aug 5, 2019
nokome added a commit that referenced this issue Aug 12, 2019
This makes breaking changes to the code related nodes:

- refactor `Code` to be a class for all code related classes without the bloat previously associated with using `SoftwareSourceCode` (previously used for `CodeExpr` and `CodeChunk`)

- add a `CodeFragment` type for inline code (using `Code` as a base class and for inline code caused issues with type maps)

- rename `CodeExpr` to `CodeExpression` for consistency with full-word-ness of `CodeFragment`

Closes #92
beneboy pushed a commit that referenced this issue Aug 31, 2019
This makes breaking changes to the code related nodes:

- refactor `Code` to be a class for all code related classes without the bloat previously associated with using `SoftwareSourceCode` (previously used for `CodeExpr` and `CodeChunk`)

- add a `CodeFragment` type for inline code (using `Code` as a base class and for inline code caused issues with type maps)

- rename `CodeExpr` to `CodeExpression` for consistency with full-word-ness of `CodeFragment`

Closes #92
@beneboy beneboy closed this as completed in deb1c51 Sep 2, 2019
stencila-ci added a commit that referenced this issue Sep 2, 2019
# [0.28.0](v0.27.0...v0.28.0) (2019-09-02)

### Bug Fixes

* **Code:** Refactor code related classes ([deb1c51](deb1c51)), closes [#92](#92)
* Fixed behaviour of ConstantSchema and EnumSchema in python executor ([c50d5ac](c50d5ac))
* **Py:** Fixed Execution timing to include entire CodeChunk ([44338e5](44338e5))
* **R:** Add include tag so collation order is correct ([3cee6d8](3cee6d8))
* **R:** Correct Datatable functions  for new schema ([c50903a](c50903a))
* **R:** Fix and improve generated bindings ([cffc5fe](cffc5fe))
* Refactor after rebasing ([f21ad6c](f21ad6c))
* Treating typed variables as declarations and other as assigns ([dbefd62](dbefd62))
* TS generation of function function and type usage in CodeError ([2f43bfa](2f43bfa))

### Features

* **Js/WIP:** Parsing of CodeChunk properties ([1fdbd1d](1fdbd1d))
* Add Parameter schema ([cf6e358](cf6e358))
* **CodeChunk:** Add more properties to CodeChunk ([49c3543](49c3543))
* **Js:** Added Handling of for statements ([e6799f6](e6799f6))
* **Js:** Adding timing of CodeChunk execution ([b1aa9cc](b1aa9cc))
* Added parsing of alters and error capturing ([3e43901](3e43901))
* **Js:** Capturing files read by readFile/readFileSync and open ([aaf3fa4](aaf3fa4))
* **Js:** Catching exceptions during parsing/execution ([e499eb4](e499eb4))
* **JS:** Added checking for empty string semaphore in imports ([d2e2d48](d2e2d48))
* **JS:** Added parsing of try/except ([81942ec](81942ec))
* **Parameter:** Add schema schemas ([d5b67b0](d5b67b0))
* **Py:** Added checking for empty string semaphore in imports ([648ac8e](648ac8e))
* **Py:** Added Exception parsing ([5e55bcb](5e55bcb))
* **Py:** Added Python args/kwargs parsing ([2f4b927](2f4b927))
* **R:** Add compilation of CodeChunks ([68a183e](68a183e))
* Add Python command line executor ([e4dbe3d](e4dbe3d))
* Added 'repeats' and 'extends' properties for Parameter ([398e658](398e658))
* Added first draft of JavaScript executor ([0bdc46e](0bdc46e))
* Added parsing of If, While etc to JS interpreter ([7c062d1](7c062d1))
* Converting matplotlib figures to ImageObjects during Py execution ([e080f6b](e080f6b))
* Converting Pandas DataFrames to Datatables in Python JSON output ([39406e5](39406e5))
* Extracting features from CodeChunks ([790f9bf](790f9bf))
@stencila-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants