Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KAD-2962 #648

Closed
wants to merge 7 commits into from
Closed

bugfix/KAD-2962 #648

wants to merge 7 commits into from

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-2962
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

When copy/paste styles in the widget editor, the __internalWidgetId attribute is copied. This causes a problem when the user tries to save the widgets. This fix makes sure the attribute isn't included when pasting styles.

@oakesjosh
Copy link
Contributor

Discussed moving the delete widgetEditorAttributesToPaste.__internalWidgetId; into the CopyPasteAttributes component

@gilbert-hernandez
Copy link
Contributor Author

@oakesjosh
Moved the fix to the CopyPasteAttributes component so it applies to other blocks.

@oakesjosh oakesjosh closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants