Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KAD-3421 #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix/KAD-3421 #644

wants to merge 1 commit into from

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3421
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

gilbert-hernandez commented Jan 8, 2025

Changed the nth-child selector to nth-of-type for Dynamic HTML blocks. When a Dynamic HTML block renders the row, it adds the section styles to a <style> tag as a sibling for each column div, which affects the nth-child selector. This change ensures that only the div elements are counted when applying some row styles.

@gilbert-hernandez
Copy link
Contributor Author

Also, updated the selector for when row breakoutLeft/breakoutRight are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant