Bug fixes & IPv6 support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 11, 2017 16:39
Signed-off-by: jack <jack@k-net.pro>
Signed-off-by: jack <jack@k-net.pro>
Signed-off-by: jack <jack@k-net.pro>
Signed-off-by: jack <jack@k-net.pro>
Signed-off-by: jack <jack@k-net.pro>
…s. Loop & filter until we find ours (or timeout) Signed-off-by: jack <jack@k-net.pro>
Signed-off-by: jack <jack@k-net.pro>
anton-belousov
requested changes
Jun 20, 2017
aioping/__init__.py
Outdated
| @@ -211,8 +206,7 @@ def sendto_ready(packet, socket): | |||
| ) | |||
| packet = header + data | |||
|
|
|||
| callback = functools.partial(sendto_ready, packet=packet, socket=socket) | |||
| asyncio.get_event_loop().add_writer(my_socket, callback) | |||
| my_socket.sendto(packet, dest_addr) | |||
There was a problem hiding this comment.
Why do we need a synchronous submission here?
Signed-off-by: jack <jack@k-net.pro>
|
Sorry for the delay and thanks for the review I am not sure how it should be done, there is a commit that should do better Tell me if it's still crap :) |
bxwllzz
suggested changes
Nov 9, 2017
aioping/__init__.py
Outdated
|
|
||
| return time_received - time_sent | ||
| if type != ICMP_ECHO_REPLY and type != ICMP6_ECHO_REPLY: | ||
| next |
There was a problem hiding this comment.
next is a build-in function in python. Do you mean continue?
Signed-off-by: Jack <jack@k-net.pro>
|
Humpf shame on me, thanks for the review |
|
@JackSlateur, @bxwllzz, thank you very much for contributing & checking this. Will update the library soon. |
Crypto-Spartan
pushed a commit
to Crypto-Spartan/aioping
that referenced
this pull request
Oct 30, 2020
Bug fixes & IPv6 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please find a batch of commits I had to make
It mixes fixes (the code does not works for me as-is) and IPv6 support
Please tell me what you think, I can rebase it if you have issue with some parts or something