add keypair package in a second workspace #102
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. What is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. What is debug access?Uses debug, reflection and dynamic code execution features. Removing the use of debug will reduce the risk of any reflection and dynamic code execution. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| @@ -1,4 +1,4 @@ | |||
| name: npm publish | |||
| name: npm publish wallet sdk | |||
| on: | |||
There was a problem hiding this comment.
fyi I couldn't find a good way to auto publish two projects in the same mono repo. But I don't imagine the KeyManager code will be changing much, so I think publishing that manually shouldn't be to terrible?
and the main SDK will still have the auto publishing capability
| export * from "./freighter"; | ||
| export * from "./ledger"; | ||
| export * from "./plaintextKey"; | ||
| // TODO - fix trezor errors |
There was a problem hiding this comment.
leaving trezor commented out for a separate PR, since giving errors
we have this ticket for reaching out to trezor
|
there are 2 "high" severity warnings from socket (same as the PR this branch is merging into) I looked into both and neither look dangerous |
* create workspace * try * try * try * try * cleanup * update anchor platform docker run * fix * fix * upgrade babel/traverse * upgrade browserify-sign * add keypair package in a second workspace (#102) * add km package * fix tests * cleanup
* fix broken test (#93) * add sep10 sign challenge txn helper (#95) * add sep10 helper method * name change * correct resp * create server module * add npm publish gha (#96) * WAL-1064 - add anchor platform integration tests (#99) * create workspace (#101) * create workspace * try * try * try * try * cleanup * update anchor platform docker run * fix * fix * upgrade babel/traverse * upgrade browserify-sign * add keypair package in a second workspace (#102) * add km package * fix tests * cleanup * add second CD (#109) * fix stellar-sdk imports (#112) * fix imports * fix * preparing for 1.4.0 release stuff (#110) * fix * fix webpack process * webpack fix (#113) * webpack fix * cleanup * add helper for parsing AnchorTransaction (#111) * add helper for parsing AnchorTransaction * use kind * add try-catch --------- Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com>
ticket
adding the keyManager code into its own workspace
this is replacing this outdated PR I posted earlier w/o workspaces, but is essentially the same deal of lifting code from old wallet-sdk Keymanager stuff to this sdk