removing phantomjs from image #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was causing build errors due to not being available on 22.04
paulbellamy
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During image build, getting errors due to no phantomjs available from apt package on ubuntu 22.04.
https://github.com/stellar/soroban-tools/actions/runs/4747312880/jobs/8432059319#step:5:8152
phantomjs is not used by anything in the test image, it was being referenced by js-sorobn-client as a dev dependency that was not used. Have related js-soroban-sdk#68 to remove it from that project. once that merges then this build should work and can merge.