SEP-38: make SEP-10 token optional for some endpoints #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
previously approved these changes
Mar 8, 2022
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
leighmcculloch
approved these changes
Mar 8, 2022
marcelosalloum
added a commit
to stellar/stellar-anchor-tests
that referenced
this pull request
Mar 29, 2022
…ices` requests, to be compliant with the change made in stellar/stellar-protocol#1144.
marcelosalloum
added a commit
to stellar/stellar-anchor-tests
that referenced
this pull request
Mar 30, 2022
…-38 (#79) ### What Update tests to make it compliant with the new version of [SEP-38](https://stellar.org/protocol/sep-38): * `QUOTE_SERVER` is actually meant to be `ANCHOR_QUOTE_SERVER`. * Since [stellar-protocol#1144](stellar/stellar-protocol#1144), only the `/quote(s)` endpoints require SEP-10 authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make SEP-10 token optional for the endpoints:
GET /infoGET /priceGET /pricesWhy
Client applications may want to show rates from multiple liquidity providers to a user, or simply display the exchange rates of an anchor's pairs before the user has indicated they want to start a transaction.
Closes #1086.