Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine inclusion fee and resource fee sections #389

Merged
merged 22 commits into from
Mar 27, 2024
Merged

Combine inclusion fee and resource fee sections #389

merged 22 commits into from
Mar 27, 2024

Conversation

briwylde08
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 mentioned this pull request Mar 26, 2024
Closed
@sydneynotthecity sydneynotthecity mentioned this pull request Mar 26, 2024
Open
ElliotFriend
ElliotFriend approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a few (maybe more than a few 😬) comments that are almost entirely nitpicks and suggestions that can be ignored.

Even if all are ignored, looks great! Really well done with this @briwylde08!

briwylde08 and others added 19 commits March 27, 2024 09:03
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
87db65d 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08
diagram*
da78250
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
6de13ca 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
3130b1c 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
cdb0239 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
ff5c23c 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
9ebbc1e 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
67a4465 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
e5ea1b0 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
451b963 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
3b20efc 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
2a285ef 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
ef88928 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
176f802 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
1e50b85 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
fb1c102 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@briwylde08 @ElliotFriend
Update docs/learn/fundamentals/fees-resource-limits-metering.mdx
99a00c3 
Co-authored-by: Elliot Voris <elliot@stellar.org>
@ElliotFriend
nginx redirects for old fee paths and pages
535f8b7
@ElliotFriend
Merge branch 'fees' of github.com:stellar/stellar-docs into fees
ae8f6ea
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

4 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

5 similar comments
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr389.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 merged commit 3d6ddc1 into main Mar 27, 2024
2 checks passed
@briwylde08 briwylde08 deleted the fees branch March 27, 2024 16:40
@ElliotFriend ElliotFriend linked an issue Mar 27, 2024 that may be closed by this pull request
Embed Canvas inclusion fee to docs #369
Closed
@ElliotFriend ElliotFriend removed a link to an issue Mar 27, 2024
Embed Canvas inclusion fee to docs #369
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElliotFriend ElliotFriend ElliotFriend approved these changes

@namankumar namankumar Awaiting requested review from namankumar

@anupsdf anupsdf Awaiting requested review from anupsdf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briwylde08 @stellar-jenkins @ElliotFriend