Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SDKs into separate pages #1280

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Split SDKs into separate pages #1280

merged 10 commits into from
Feb 13, 2025

Conversation

briwylde08
Copy link
Contributor

@stellar-jenkins
Copy link

@briwylde08
Copy link
Contributor Author

Tagging @ElliotFriend because I know you had some naming concerns.

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

Could we change the top nav menu item so it points to the page about all SDKs? At the moment folks are dropping straight into client SDKs.

I think the page about all SDKs could also discuss the two different types there too. So that folks are dropped into a page that helps them know where to go.


Each SDK has its own source code and documentation. Learn how to use a specific SDK by referring to the documentation.

## Soroban Rust SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a section below this, ## Soroban Rust Token SDK.

It is available here: https://docs.rs/soroban-token-sdk, and is also maintained by SDF and contains utilities for building tokens and can be used in addition to the soroban-sdk.

We could add this in a follow up.

cc @sisuresh

briwylde08 and others added 4 commits February 11, 2025 16:44
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@stellar-jenkins
Copy link

3 similar comments
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@briwylde08
Copy link
Contributor Author

@leighmcculloch https://developers.stellar.org/docs/tools/sdks this is kind of the landing page for SDKs. Does this work for helping guide the user?

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@leighmcculloch
Copy link
Member

@leighmcculloch developers.stellar.org/docs/tools/sdks this is kind of the landing page for SDKs. Does this work for helping guide the user?

Yup, that's what I was meaning, having the top nav link directly to that page where there the boxes to click through to the two. We may want to have a small blurb or image of some kind.

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@briwylde08
Copy link
Contributor Author

@leighmcculloch changes made, wdyt?

@stellar-jenkins
Copy link

@leighmcculloch
Copy link
Member

Looks great. I think there would be valuable in moving the BYOSDK under the Contract SDK? If there's a way to do that.

@stellar-jenkins
Copy link

@briwylde08 briwylde08 merged commit dffd34e into main Feb 13, 2025
2 checks passed
@briwylde08 briwylde08 deleted the sdk-pages branch February 13, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants