Legacy tx sets: avoid using read-only LCL meant for main thread only #4659
+46
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d18af91 to
ebdffd5
Compare
dmkozh
reviewed
Mar 4, 2025
ebdffd5 to
c6b8e97
Compare
dmkozh
previously approved these changes
Mar 4, 2025
dmkozh
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like parallel ledger close is tripping
threadIsMainassert ingetLastClosedLedgerHeaderinprepareForApply. This only impacts new networks in protocol 0 (which use legacy tx sets). Fix is easy: callers of prepareForApply typically hold a thread-safe LCL already, so use that instead. We didn't catch this in tests because tests use a custom upgrade logic, such that we upgrade to generalized transactions sets on genesis.