Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BucketListDB Random Eviction Cache #4632

Merged
merged 2 commits into from
Feb 7, 2025
Merged

BucketListDB Random Eviction Cache #4632

merged 2 commits into from
Feb 7, 2025

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Jan 29, 2025 •
edited
Loading

Description

Resolves #3696

Adds a random eviction cache to LiveBucket using DiskIndex. Currently, I've set the default to cache up to 25% of Bucket entries, which puts total stellar-core memory usage at about 5-6 GB by default.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson SirTyson force-pushed the bl-random-eviction-cache branch from d8fafbb to 144938b Compare February 4, 2025 03:09
@SirTyson SirTyson marked this pull request as ready for review February 4, 2025 03:09
@SirTyson SirTyson requested review from dmkozh and sisuresh February 4, 2025 03:09
dmkozh
dmkozh reviewed Feb 4, 2025
View reviewed changes
dmkozh
dmkozh approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve this; I think we can change the config semantics later if we want. This still needs to be rebased though.

@SirTyson SirTyson force-pushed the bl-random-eviction-cache branch from 15f85ed to 8df4c8c Compare February 7, 2025 16:44
@SirTyson
Copy link
Contributor Author

SirTyson commented Feb 7, 2025

Forgot to approve this; I think we can change the config semantics later if we want. This still needs to be rebased though.

Done

@SirTyson SirTyson force-pushed the bl-random-eviction-cache branch from 8df4c8c to 8af38d8 Compare February 7, 2025 17:58
@dmkozh dmkozh enabled auto-merge February 7, 2025 18:04
@dmkozh dmkozh added this pull request to the merge queue Feb 7, 2025
Merged via the queue into stellar:master with commit bf55e27 Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@sisuresh sisuresh Awaiting requested review from sisuresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add persistent cache to BucketListDB
2 participants
@SirTyson @dmkozh