Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Soroban settings files for SLP-0001 #4571

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Update Soroban settings files for SLP-0001 #4571

merged 3 commits into from
Jan 15, 2025

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Dec 10, 2024 •
edited
Loading

Description

Update Soroban settings files for https://github.com/stellar/stellar-protocol/blob/master/limits/slp-0001.md. This maintains the 5 to 1 ratio between ledger and tx settings.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

anupsdf
anupsdf approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@anupsdf anupsdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Let's mention that this maintains the tx:ledger ratio of 1:5

@sisuresh sisuresh marked this pull request as ready for review January 3, 2025 00:46
@sisuresh sisuresh added this pull request to the merge queue Jan 15, 2025
Merged via the queue into stellar:master with commit e1cf3d1 Jan 15, 2025
13 checks passed
@sisuresh sisuresh deleted the testnetslp branch January 15, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsdf anupsdf anupsdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisuresh @anupsdf