Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prefetch tests #4410

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix prefetch tests #4410

merged 1 commit into from
Aug 1, 2024

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Aug 1, 2024

Description

Prefetch tests currently hardcode protocol version 20, meaning they break in other protocols. This removes the hardcoded version.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@marta-lokhova marta-lokhova enabled auto-merge August 1, 2024 18:12
@marta-lokhova marta-lokhova added this pull request to the merge queue Aug 1, 2024
Merged via the queue into stellar:master with commit e92596f Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-lokhova marta-lokhova marta-lokhova approved these changes

@ThomasBrady ThomasBrady ThomasBrady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SirTyson @ThomasBrady @marta-lokhova