Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TxAdverts test #4298

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix TxAdverts test #4298

merged 1 commit into from
Apr 26, 2024

Conversation

sisuresh
Copy link
Contributor

Description

The advert queue testcase currently triggers this releaseAssert.

We could also just set an empty callback instead of checking if it fired.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from graydon April 26, 2024 16:54
@graydon
Copy link
Contributor

graydon commented Apr 26, 2024

r+ 0152a98

@latobarita latobarita merged commit d606298 into stellar:master Apr 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon Awaiting requested review from graydon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisuresh @graydon @latobarita