Flag-protect the extra Soroban fee meta. #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
approved these changes
Apr 1, 2024
|
r+ 2b813de |
latobarita
added a commit
that referenced
this pull request
Apr 2, 2024
Flag-protect the extra Soroban fee meta. Reviewed-by: marta-lokhova
|
@dmkozh looks like there's an issue in |
|
@dmkozh we need to merge this PR asap to unblock v20.4.0, so in case you get to it before me, please feel free to r+ once the tests are passing. |
|
r+ 18ba9ba |
sisuresh
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flag-protect the extra Soroban fee meta.
The new meta has to be parsed with the up-to-date XDR parser and thus has to be optional for a while.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)