Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stability fixes #4240

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Stability fixes #4240

merged 2 commits into from
Mar 21, 2024

Conversation

marta-lokhova
Copy link
Contributor

No description provided.

@marta-lokhova marta-lokhova requested a review from graydon March 12, 2024 22:27
graydon
graydon approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though you don't need to seed the sub-PRNG from the same seed as the global one, you can just ask the global PRNG for a pseudo-random number drawn from its stream, to use as the sub-PRNG's seed (if you want to avoid the change to Math.{cpp,h})

@graydon
Copy link
Contributor

graydon commented Mar 21, 2024

r+ 8adb15c

@latobarita latobarita merged commit 9713812 into stellar:master Mar 21, 2024
15 checks passed
@graydon graydon mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marta-lokhova @graydon @latobarita