New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Binary Fuse Filter memory access #4618

Closed

SirTyson opened this issue Jan 9, 2025 · 0 comments · Fixed by #4619

Assignees

Labels

bug

Contributor

SirTyson commented Jan 9, 2025

No description provided.

SirTyson added the bug label

SirTyson self-assigned this

SirTyson mentioned this issue

Harden bloom filter vector access #4619

Merged

6 tasks

github-merge-queue bot pushed a commit that referenced this issue


          Harden bloom filter vector access (#4619)

e82e15a

# Description

Resolves #4618

This hardens Binary Fuse Filter constructor code to use protected vector
lookups instead of C style array dereferencing.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)

SirTyson closed this as completed in #4619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment