Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history: results and tx set iteration is duplicated #4567

Closed
marta-lokhova opened this issue Dec 6, 2024 · 0 comments · Fixed by #4655
Closed

history: results and tx set iteration is duplicated #4567

marta-lokhova opened this issue Dec 6, 2024 · 0 comments · Fixed by #4655
Assignees
@SirTyson
Labels
bug

Comments

@marta-lokhova
Copy link
Contributor

Currently, the same iteration algorithm in the history subsystem is duplicated three times:

This logic is already error-prone enough due to allowed gaps, no reason to duplicate it. We can centralize the algorithm in one function with a little bit of refactoring/templating.
@ThomasBrady ThomasBrady mentioned this issue Feb 5, 2025
Closed
6 tasks
@SirTyson SirTyson assigned SirTyson and unassigned ThomasBrady Feb 26, 2025
@SirTyson SirTyson mentioned this issue Feb 27, 2025
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 28, 2025
@marta-lokhova
Unified iterating through txset history entries (#4655)
a299bf4 
# Description

Resolves #4567.

# Checklist
- [ ] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [ ] Compiles
- [ ] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirTyson SirTyson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unified iterating through txset history entries SirTyson/stellar-core
3 participants
@ThomasBrady @marta-lokhova @SirTyson