Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable checkStellarCoreMajorVersionProtocolIdentity check #3810

Closed
sisuresh opened this issue Jul 5, 2023 · 2 comments · Fixed by #4321
Closed

Enable checkStellarCoreMajorVersionProtocolIdentity check #3810

sisuresh opened this issue Jul 5, 2023 · 2 comments · Fixed by #4321
Assignees
@graydon
Labels
bug

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Jul 5, 2023

The checkStellarCoreMajorVersionProtocolIdentity check here was commented out in #3808, but needs to be re-enabled in a way that works.
@sisuresh sisuresh added the bug label Jul 5, 2023
@sisuresh sisuresh mentioned this issue Jul 5, 2023
Merged
6 tasks
@MonsieurNicolas
Copy link
Contributor

would that check never work for vnext? Like when we release 20.0, vnext will want to have a protocol version that is 21

@sisuresh
Copy link
Contributor Author

sisuresh commented Jul 8, 2023

Yeah the check as-is is not what we want. This issue is about re-enabling the check in a way that works, or making sure it can stay removed.

@graydon graydon mentioned this issue May 14, 2024
Merged
latobarita added a commit that referenced this issue May 22, 2024
@latobarita
Merge pull request #4321 from graydon/bug-3810-core-major-version-pro…
1bc57e7 
…tocol-identity-check

Fix #3810, re-enable checkStellarCoreMajorVersionProtocolIdentity

Reviewed-by: sisuresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3810, re-enable checkStellarCoreMajorVersionProtocolIdentity graydon/stellar-core
3 participants
@graydon @MonsieurNicolas @sisuresh