Update to remove ScSpecTypeSet #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Aug 21, 2023
75a2f86 to
47b1694
Compare
47b1694 to
cca677e
Compare
|
This is almost ready to land but it needs someone to bump the go XDR reference I think? I don't quite know how to do that. @2opremio can you take it from here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sketch of the change necessary to adapt to the removal of ScSpecTypeSet upstream. It's incomplete and needs to be further updated with proper git refs as upstream revs land.
Reflects stellar/rs-soroban-sdk#1054 which reflects stellar/rs-stellar-xdr#291 which reflects stellar/stellar-xdr#136 which addresses stellar/stellar-xdr#135 which resulted from stellar/rs-soroban-sdk#979