SEP-38: update SEP-38 tests based on stellar/stellar-protocol#1204 #86
Conversation
…in the stellar network. This is related to stellar/stellar-protocol#1149.
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
|
Preview is available here: |
|
|
||
| const notValidFiat = parts.length === 2 && parts[0] !== "iso4217"; | ||
| const notValidStellar = parts.length === 3 && parts[0] !== "stellar"; | ||
| const notValidAtAll = parts.length < 2 || parts.length > 3; | ||
| if (notValidFiat || notValidStellar || notValidAtAll) { |
There was a problem hiding this comment.
I made this change because since stellar/stellar-protocol#1149, SEP-31 accepts delivering on-chain access as well.
| @@ -78,6 +81,7 @@ export const returnsValidResponse: Test = { | |||
| sell_asset: this.context.expects.sep38StellarAsset, | |||
| buy_asset: this.context.expects.sep38OffChainAsset, | |||
| sell_amount: "100", | |||
| context: "sep31", | |||
There was a problem hiding this comment.
This is tough, because an anchor could support SEP-38 for SEP-6, and we'd be sending an invalid context value. Maybe we should add a config attribute that allows the user to indicate which context value should be used? Or maybe we can infer which value to use based on the tests being run?
There was a problem hiding this comment.
Also, did we update the config file info displayed in the UI after adding SEP-38 support? Or does SEP-38 not require any config currently?
There was a problem hiding this comment.
Sep38 doesn't require any context at the moment. I'll add the context in the next PR and make it configurable in the sep config.
…e tested (#87) ### What SEP-38 now requires a config file to indicate which contexts should be tested. Also, update some SEP-38 tests to execute the request once for each context. ### Why The SEP-38 `GET /price` and `POST /quote` request parameters have a new mandatory field called `context`, that can be set to "sep6" or "sep31". With the new configuration file, Anchors can choose which context(s) should be used in the tests. Addresses #86 (comment). ### Pending * Update documentation. I'll do that in another PR so it's easier to review.
What
Update SEP-38 tests based on stellar/stellar-protocol#1204. The changes include:
GET /priceandPOST /quotenow require the mandatorycontextrequest parameter.GET /priceandGET|POST /quotenow return the mandatory response parameterstotal_priceandfee.